Remove our modified older typings #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So is this ready to go? CAN I PULL IT? CAN I PRESS THE BIG RED BUTTON |
|
haha branchname |
|
There needs to be an emoji better than laughing for how I feel about that branch name |
|
What do we do when I do want it merged lol |
|
When 1.6 came out, I looked into doing this but the crazy amount of builds errors made me rethink that so @xconverge thanks for taking this on. |
|
Yea I am an idiot |
|
total cop out here for dealing with strictNullChecks... |
xconverge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doing these updates:
https://code.visualstudio.com/updates/v1_6#_extension-authoring
So that we can use v1.0.5 of the vscode.d.ts node module:
microsoft/vscode-extension-vscode#53