Fixes #1513: Backspace on middle of whitespace only line fails #1514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I fixed issue #1513. This issue only occurs when Configuration.expandTab is turned on.
The main behavioral decision I made is that if you press backspace on a whitespace only line, it deletes both to the next "tab" as well as all the whitespace after it.
I'm unsure about a couple of things
I'd like to create tests, but from looking through the repo, I don't see how to set Configuration.expandTab to be true while running these tests.
When running the tests locally, I get 56 tests failing, with or without my change. I don't really know what I'm supposed to do there (I thought I would try running the tests on CI, and cool! They passed.).
Cheers,
Horace