Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical split shortcut keys #1795

Merged
merged 1 commit into from Jun 2, 2017

Conversation

beefsack
Copy link
Contributor

@beefsack beefsack commented Jun 1, 2017

This PR binds C-w v to workbench.action.splitEditor, achieving similar functionality to what happens in Vim.

I've previously manually maintained a shortcut to match the Vim vertical split shortcut, but thought it might be helpful to add it for everyone else. Please close if it's not a complete fit, I'm happy to maintain the shortcut configuration myself.

At the moment it's just the binding, had a look at the automated tests and not entirely sure how I'd go about testing it. If this is required, some rough direction would be greatly appreciated.

Keep up the great work, this is one of the best Vim modes I've ever used, if not the best.

Relates to #1451.

@Chillee
Copy link
Member

Chillee commented Jun 2, 2017

These look pretty good to me!

You're right that we don't have automated tests for these... It seems pretty difficult and not very helpful to do something like that.

Thanks for the PR! And thanks for the praise!

@Chillee Chillee merged commit 08f3b0b into VSCodeVim:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants