Fixes #1814: Undo history getting deleted when file changes #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this. I tried it out and I didn't see any immediate breaking changes, while it fixes the big issue we're having right now. |
|
Actually, people actually seem to be bugged by that behavior. I'll take another look as to how we can revert it back to the old behavior. |
|
What's happening with this? Isn't the expected behaviour to delete the undo history after an external file change, i.e. checking out a new git branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm currently fixing the issue by simply getting rid of the offending code. So pretty much what happens when you remove that code is that when the file changes on disk, an undo simply reverts back the disk file change first, which I think is perfectly fine behavior.