Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disableExtension configuration should follow pattern of rest of configs #3318

Merged
merged 1 commit into from Jan 2, 2019

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jan 2, 2019

What this PR does / why we need it:

  • refactoring the disableExtension configuration such that it follows the pattern for the rest of the configs in the manner in which it's configuration is retrieved and set.
  • when toggling VIM, the disableExtension configuration will not persist through sessions

Which issue(s) this PR fixes

Special notes for your reviewer:

@jpoon jpoon merged commit a505b47 into master Jan 2, 2019
@jpoon jpoon deleted the disableext branch January 2, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant