Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of "ge" command #3322

Merged
merged 6 commits into from Jan 11, 2019
Merged

Fix the issue of "ge" command #3322

merged 6 commits into from Jan 11, 2019

Conversation

zhuzisheng
Copy link
Contributor

What this PR does / why we need it:
the "ge" command doesn't work the same as in Vim.

Which issue(s) this PR fixes
Fix #3285

Special notes for your reviewer:

@xconverge
Copy link
Member

Please add a test to cover this functionality

@zhuzisheng
Copy link
Contributor Author

Please add a test to cover this functionality

OK.

@zhuzisheng
Copy link
Contributor Author

zhuzisheng commented Jan 10, 2019 •
edited

I add two new tests for "ge" command.

@xconverge
Copy link
Member

Thank you! LGTM

@xconverge xconverge merged commit bab129d into VSCodeVim:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ge doesn't go to the previous line
3 participants
@zhuzisheng @xconverge @bezhu