New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small deletions to small delete register #3544
Conversation
Travis tests have failedHey @rickythefox, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 01db7090-3c41-11e9-a665-7766e5f56462 |
Will fix the failing test and re-open. |
Travis tests have failedHey @rickythefox, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 1b094e00-3d0b-11e9-ae74-63667cf8398f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a maintainer, just reviewing some code to try to get to know the codebase better and help out. Your changes look good to me, though mentioned a way above to make things a bit more comprehensive!
Travis tests have failedHey @rickythefox, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 4953f6d0-40f7-11e9-a18c-4113a40d83d6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! (though you'll have to wait for a real maintainer to actually review/approve/merge)
Looks like a build flake to me though, you might be able to fix the typos above and repush to trigger another build:
|
Adds small deletions to small delete register.
Fixes #3492.