Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct replacement confirmation text #3722

Merged
merged 2 commits into from May 4, 2019
Merged

Correct replacement confirmation text #3722

merged 2 commits into from May 4, 2019

Conversation

J-Fields
Copy link
Member

@J-Fields J-Fields commented May 3, 2019

What this PR does / why we need it:
The confirmation text for replacing with %s/oldText/newText/gc, for instance, would read:

Replace with oldText?

Now it reads

Replace with newText?

Which issue(s) this PR fixes
Fixes #3715

Special notes for your reviewer:

@jpoon jpoon merged commit b342a75 into VSCodeVim:master May 4, 2019
@TravisBuddy
Copy link

Hey @J-Fields,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3a90a2f0-6e2a-11e9-b7a6-6b5a2442fe30

@J-Fields J-Fields deleted the replace-confirm-text branch May 4, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace (:%s) confirm text is wrong
3 participants
@J-Fields @TravisBuddy @jpoon