Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to registers #3728

Merged
merged 8 commits into from
May 6, 2019
Merged

Various improvements to registers #3728

merged 8 commits into from
May 6, 2019

Conversation

J-Fields
Copy link
Member

@J-Fields J-Fields commented May 5, 2019

What this PR does / why we need it:

  • Implement the /, :, and % registers
  • Stops read-only registers from being written to directly
  • Allows the : register to be used as a macro to repeat the last command
  • Improves the behavior of :reg (hiding _ register, allowing multiple arguments)

Which issue(s) this PR fixes
Fixes #3542
Fixes #3604
Fixes #3605
Fixes #1775
Fixes #3606
Fixes #3610

Special notes for your reviewer:
This PR does a lot of different things, but they're all small changes and mostly related. I'm happy to break this up if it's easier for you; let me know!

@jpoon
Copy link
Member

jpoon commented May 6, 2019

Wow 😮 . Thanks for all the recent PRs!

@jpoon
Copy link
Member

jpoon commented May 6, 2019

LGTM. Will merge after this build passes.

@jpoon jpoon merged commit 1ef304e into VSCodeVim:master May 6, 2019
@J-Fields J-Fields deleted the registers branch May 6, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment