Fix gq to handle tab indentation #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3929 |
|
Ah thanks! I checked a couple months ago to see if there was an issue for this and (incorrectly) assumed none had been created in the interim 🙂 |
|
LGTM. Why do you assume it won't pass on CI though? |
There's a comment above the old commented-out tests that says they don't work on Travis – I can try uncommenting them all to see if they succeed. |
|
The gq tests are pretty slow, but they're passing! |
The `gq` command to "reflow" selected text in visual line mode didn't properly handle tabs, replacing them with spaces.
They used to "run poorly on Travis".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The
gqcommand to "reflow" selected text in visual line mode didn't properly handle tabs, replacing them with spaces.Which issue(s) this PR fixes: (none, I can create one if needed)
Special notes for your reviewer: I added another commented-out
gqtest case under the assumption that it would also "run poorly on Travis". It passes locally though (along with the two old commented-outgqtests).