Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim.statusBarColors for 5 remaining modes #4185

Merged
merged 2 commits into from Nov 2, 2019

Conversation

thisisrandy
Copy link
Contributor

What this PR does / why we need it: Adds vim.statusBarColors for 5 remaining modes, i.e. CommandInProgress, etc. Note that this already works without the change, but the five modes added in this commit aren't officially listed as options. The default coloring for each appears to be the same as the standard VSCode coloring, which happens to be #007ACC

Which issue(s) this PR fixes
(none)

Special notes for your reviewer: Builds fine, but testing fails for me in master with

Error: Error: Cannot find module '/home/randy/git/VSCodeVim/test'
	at t.ExtHostExtensionService._doHandleExtensionTests (/home/randy/git/VSCodeVim/.vscode-test/vscode-1.39.2/VSCode-linux-64/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:670:756)

Error: Cannot find module '/home/randy/git/VSCodeVim/test': Error: Error: Cannot find module '/home/randy/git/VSCodeVim/test'
	at t.ExtHostExtensionService._doHandleExtensionTests (/home/randy/git/VSCodeVim/.vscode-test/vscode-1.39.2/VSCode-linux-64/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:670:756)

This is probably a configuration issue on my end (I'm unfamiliar with vscode test), so if you'd like to point me in the right direction, I can confirm that the test passes as well. To be clear, running

> yarn install
> yarn test

on a clean clone of master produces the above output.

thisisrandy and others added 2 commits October 16, 2019 17:04
Note that this already works without the change, but the five modes
added in this commit aren't officially listed as options. The default
coloring for each appears to be the same as the standard VSCode
coloring, which happens to be #007ACC
@jpoon jpoon merged commit 9ca121d into VSCodeVim:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants