Fixed backward search from end of word (VSCodeVim #4266) #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Searching with 'N' after /e at the end of search fixed - Changed comparison for next search result - Change made in getNextSearchMatchRange in searchState.ts
|
Thanks for the PR! A regression test would be great. |
- Searches '/two/e' then types 'N' and checks cursor moved accordingly
|
Alright the regression test is up, let me know if everything looks good! |
|
LGTM, thanks for the PR! I noticed while testing that if |
J-Fields
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed backward search from end of word (VSCodeVim #4266)
What this PR does / why we need it:
Fix the issue reported,
/word/eNAlso fixed the larger issue, where backward search was broken in general. For example, the previous steps could be repeated with
?word?e, where backward search withnalso did move the cursor.Which issue(s) this PR fixes
#4266
Special notes for your reviewer:
We tested this manually to verify it works, please let us know if we should add actual tests to the suite.