Make sure DocumentChange.timestamp is always set #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like it could be incorrect sometimes, and we should make sure all changes are either declared finished at their creation or finished before they can be undone. Also remove an instance of suite.only() that slipped in...whoops Fixes #4351
|
When is the next release expected? Would love to start using this fix 👍 |
|
@raudabaugh Sorry, was meaning to get a few other small things into the patch release but life got busy. I'll do my best to release tonight. |
|
this annoying error has been torturing me 😭😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like it could be incorrect sometimes, and we should make sure all changes are either declared finished at their creation or finished before they can be undone.
Also remove an instance of suite.only() that slipped in...whoops
Fixes #4351