Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensionKind #4435

Merged
merged 3 commits into from Dec 29, 2019
Merged

Update extensionKind #4435

merged 3 commits into from Dec 29, 2019

Conversation

cvaldev
Copy link
Contributor

@cvaldev cvaldev commented Dec 29, 2019

Fixes #4379

The old "ui" value (as a string) maps to this type for backwards compatibility, but is considered deprecated.

@J-Fields
Copy link
Member

I think ["ui", "workspace"] is correct, but not 100% sure. Do you have a good explanation for this, or did you choose this only because it's equivalent to what we had before?

@cvaldev
Copy link
Contributor Author

cvaldev commented Dec 29, 2019

@J-Fields Sorry, I should have cited my quote. I chose it because according to this it is the equivalent of what we had before.

"extensionKind": ["ui", "workspace"] — Indicates the extension prefers to run as a UI extension, but does not have any hard requirements on local assets, devices, or capabilities. When using VS Code, the extension will run in VS Code's local extension host if it exists locally, otherwise will run in VS Code's workspace extension host if it exists there. When using VS Online's browser-based editor, it will run in the remote extension host always (as no local extension host is available). The old "ui" value (as a string) maps to this type for backwards compatibility, but is considered deprecated.

@J-Fields
Copy link
Member

Cool, just checking. I think this is right, and if it causes issues for anyone we can always change it. Thanks!

@J-Fields J-Fields merged commit 0635a37 into VSCodeVim:master Dec 29, 2019
@cvaldev cvaldev deleted the refactor branch December 29, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extensionKind as a string is now deprecated
2 participants