Update statusbar with result of ex command from neovim #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
reviewed
Jan 4, 2020
There are two cases in which we pass an ex command to neovim for execution, but currently only one of them displays the result in the status bar. This commit brings the second case in line with the first so that the result of running the command is displayed.
J-Fields
force-pushed
the
display-neovim-errors
branch
from
8a8b4e1
to
7364ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I noticed that when running certain ex commands with neovim integration enabled, I wasn't seeing any output in the statusbar, regardless of the success or failure of the command. As a result I wasn't sure if commands had been successful or not.
On investigation I realised that there are two cases in which the extension passes an ex command to neovim for execution, but currently only one of them displays the result in the status bar. This commit brings the second case in line with the first so that the result of running the command is displayed:
Which issue(s) this PR fixes
As it was a simple fix I decided to just go ahead and make a PR rather than creating an issue.
Special notes for your reviewer:
As a side-note, watching the tests run was extremely cool. Nice work on those!