New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor <C-a> logic #4469
Refactor <C-a> logic #4469
Conversation
I don't know what this is in reference to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I'm not familiar with this part of the codebase, but everything seems reasonable.
Sorry for my poor English. XD |
Wait, I noticed a small problem when processing |
Ok, fixed! |
Is there anything blocking on merging of this pull request? I've compiled and use my personal fork for more than a month and haven't seen any bug related to this. |
Travis tests have failedHey @ldm0, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 705f9b30-989e-11ea-9e63-f59e35534577 |
6a69912
to
d8f112a
Compare
Travis tests have failedHey @ldm0, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 89868a50-98e5-11ea-860e-87b20eb63714 |
Sweet, thanks a bunch! I'll admit I don't really know enough firsthand to verify the specifics of how all this parsing is done in Vim, but it seems you've been thorough, the changes seem reasonable, and the tests look good, so I'm comfortable merging this. |
The reason
I've noticed the code about
<C-a>
and<C-x>
is very fragile.So I refactored it.
What this PR achieves
This PR totally fixes #4308, fixes #4457 and more.
Please check newly-added tests to get part of what this PR achieves.
These tests all fails without this PR, all of them are the correct behavior of original vim.
Now it's behavior on
<C-a>
and<C-x>
is 99% similiar to the oiginal Vim.To the maintainer:
PLZ don't ignore my pull request again... :-/
If something went wrong, at least give me a hint.