Fix wrong return in ModeHandlerMap.get #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatanugraha
requested review from
jpoon and
J-Fields
and removed request for
jpoon
J-Fields
reviewed
Feb 24, 2020
|
Nice catch, thanks for the PR! I'll take a closer look later but this seems reasonable and does fix the issue, I think. |
J-Fields
approved these changes
Feb 25, 2020
Closed
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, in my setup, this resolves #4479, #3277
From what i can observe, here's what i found to arrive to this conclusion:
vscode.window.onDidChangeActiveTextEditori always getlastClosedModeHandler = undefineddespite that the current file is exists onModeHandlerMaplastClosedModeHandler = undefinedjumping from current file doesn't push it to the jump stack