Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix g~ #4641

Merged
merged 9 commits into from Apr 18, 2020
Merged

Fix g~ #4641

merged 9 commits into from Apr 18, 2020

Conversation

lusingander
Copy link
Contributor

What this PR does / why we need it:

Fix two behaviors for g~ and add some tests on ~/g~ in visual mode.

  • Support g~~
    • It was not implemented.
  • Support g~ in visual block mode
    • It worked in visual mode and visual line mode.
    • gu and gU also worked in visual block mode.
  • Add some tests

Which issue(s) this PR fixes

Fixes #4567

Special notes for your reviewer:

@jpoon jpoon merged commit af3d04d into VSCodeVim:master Apr 18, 2020
@lusingander lusingander deleted the feature/g-tilde-tilde branch April 18, 2020 04:23
berknam pushed a commit to berknam/Vim that referenced this pull request May 5, 2020
@lusingander @berknam
Fix g~ (VSCodeVim#4641)
709939e 
* Implement "g~~"
* Add some tests in visual mode
* Support g~ in visual block mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support g~~
3 participants
@lusingander @J-Fields @jpoon