Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added escaped search string in global search state #4656

Merged
merged 2 commits into from Mar 17, 2020

Conversation

vikashgaya916
Copy link
Contributor

What this PR does / why we need it:
Cancelled Searched not being added to search history.
/foobar<Esc>, then /<C-p>. Notice "foobar" does not show up.

Which issue(s) this PR fixes
fixes #4650

Special notes for your reviewer:
Let me know on the issues with the PR as this is my first open source PR.

Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a bunch!

@J-Fields J-Fields merged commit c05e358 into VSCodeVim:master Mar 17, 2020
@vikashgaya916 vikashgaya916 deleted the Issue-4650 branch March 17, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelled searches should be added to history
3 participants