Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search with count #4675

Merged
merged 5 commits into from Mar 26, 2020
Merged

Fix search with count #4675

merged 5 commits into from Mar 26, 2020
+74 −2

Conversation

lusingander
Copy link
Contributor

What this PR does / why we need it:

[count]/[word](and [count]?[word]) is not working.
And d[count]/[word] is not working either.

Which issue(s) this PR fixes

Fixes #4669
Fixes #2464

Special notes for your reviewer:

d[count]?[word] is not working yet, and no tests added.
Because d?[word] doesn't work in the first place (#4506), so this is another problem.

J-Fields
J-Fields requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! d2/foobar should be equivalent to 2d/foobar; would you mind adding a test or two for this?

@J-Fields J-Fields added this to the v1.14.0 milestone Mar 25, 2020
@lusingander
Copy link
Contributor Author

@J-Fields
Thanks for the review, I added a test pattern of d[count/[word]!

@J-Fields
Copy link
Member

Much appreciated!

@J-Fields J-Fields merged commit 0c9b226 into VSCodeVim:master Mar 26, 2020
@lusingander lusingander deleted the fix/search-with-count branch March 26, 2020 14:48
@J-Fields J-Fields removed this from the v1.15.0 milestone May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nth (Numbered powered) search doesn't work Support d4/x
2 participants
@lusingander @J-Fields