Fix cursor position after executing J in visual mode
#4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Fields
reviewed
Mar 30, 2020
# Conflicts: # test/mode/modeVisual.test.ts # test/mode/modeVisualLine.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The cursor position after executing
Jcommand in visual (line / block) mode is different from expected.e.g.
In the following state, for example,
now, if execute
vjjjJ, we will get the following state in the original Vim.(The cursor should be in the space in front of the last word.)
but now, it's like this:
the same is true for visual line mode and visual block mode.
Which issue(s) this PR fixes
Special notes for your reviewer:
Same fix is not made for
gJbecause[count]gJdoesn't work properly... (#2207)