Fix VisualLineMode leaving selection after escape #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Fields
reviewed
Apr 19, 2020
|
LGTM, other than small nitpick |
berknam
added a commit
to berknam/Vim
that referenced
this pull request
May 5, 2020
With the new refactors to the modeHandler.updateView if you go into VisualLine mode, then escape to normal mode, then reselect with 'gv' and escape again, it goes to normal mode but leaves the selection visible, because the 'visualLineStartColumn' is undefined. Fixes VSCodeVim#4716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the new refactors to the modeHandler.updateView if you go into VisualLine mode, then escape to normal mode, then reselect with 'gv' and escape again, it goes to normal mode but leaves the selection visible, because the 'visualLineStartColumn' is undefined.
Which issue(s) this PR fixes
Fixes issue #4716