Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macros not updating cursorsInitialState before each action #4830

Merged
merged 2 commits into from May 11, 2020

Conversation

berknam
Copy link
Contributor

@berknam berknam commented May 11, 2020

Fix macros not updating cursorsInitialState before each action
fixes #4827

On issue #4827 when it makes the second 'yy' to yank line the YankOperator will set the cursors to cursorsInitialState which hasn't been changed since the beginning of the macro replay. The cursorsInitialState should have the cursors state before each action.

Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-Fields J-Fields merged commit bbc7307 into VSCodeVim:master May 11, 2020
@berknam berknam deleted the fixMacros branch May 12, 2020 16:34
J-Fields pushed a commit that referenced this pull request May 12, 2020
After the PR #4830 I found weird that none of the tests captured the issue #4827.

After looking up the tests I found that there were no macro tests that handled multiple lines on same macro (like what happens on that issue) so decided to create a new test to prevent future issues like that one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macros behave strange
2 participants