-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: search backwards with operator #5041
Bugfix: search backwards with operator #5041
Conversation
Travis tests have failedHey @sql-koala, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 87b4d3b0-c85d-11ea-8ad2-cd0863c1f5b3 |
Travis tests have failedHey @sql-koala, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 161d51d0-c85f-11ea-8ad2-cd0863c1f5b3 |
Travis tests have failedHey @sql-koala, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: dcefcc60-c860-11ea-8ad2-cd0863c1f5b3 |
Travis tests have failedHey @sql-koala, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 43a9c090-c862-11ea-8ad2-cd0863c1f5b3 |
Travis tests have failedHey @sql-koala, Node.js: 12if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 8c692540-c863-11ea-8ad2-cd0863c1f5b3 |
Finally, you cant do test driven development better :| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thank you!
Must have banged my head against the wall many times, 🤯 but it worked out |
🙂 Feel free to submit an issue about your test situation - it's much nicer when you can run them locally |
Have you tried using docker for tests? All you have to do is install docker and then run |
What this PR does / why we need it:
This PR removes an unnecessary restriction that prevents search backwards ("?") with an operator.
First build fails on new test.
Which issue(s) this PR fixes
Fixes #4506
Fixes #4647
Special notes for your reviewer:
This condition prevents "?" after an operator.
&& vimState.recordedState.operator === undefined
But it is not needed because
doesActionApply
is smart enough to figure out, that "?" after "g" should not trigger the search command (you can also type "cg?" without messing vim up). (I did capture and log the result of super() ).So we can remove the condition. But then we can remove the whole method because it is just default inherited code.