Ctrl+a and Ctrl+x now create undo points correctly and can be repeate… #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will definitely work, but the ideal way to do this would just be to make them into Commands rather than Movements. Movements do not create undo points, but Commands do. |
|
Hmm ok, I tried changing it to inherit from BaseCommand since that was my first thought, but it was doing something funky somewhere later down the line...I will check again |
|
Ready to go? |
|
good to go |
|
Great! Thanks again, @xconverge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will probably close #633 after this and PR #634 get merged