Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show command and search when showmodename is disabled #7021

Merged
merged 1 commit into from Aug 26, 2021

Conversation

BlakeWilliams
Copy link
Contributor

@BlakeWilliams BlakeWilliams commented Aug 23, 2021

What this PR does / why we need it:

When showmodename is disabled the mode is hidden but the search and
in-progress command text is also hidden.

This change updates the logic to take the command line and search
progress into account when determining if the status should be updated.
Now when showmodename is disabled, you can still see the command
or search in-progress.

The old behavior of hiding all the text can be achieved by right
clicking the status bar and hiding the "Vim Command Line" entry. The
only difference is that macro information will also be hidden.

Which issue(s) this PR fixes
N/A. This was a quick change to make so I didn't open an issue. Happy to open one if preferred/necessary though!

Special notes for your reviewer:
N/A

When `showmodename` is disabled the mode is hidden but the search and
in-progress command text is also hidden.

This change updates the logic to take the command line and search
progress into account when determining if the status should be updated.

The old behavior of hiding all the text can be achieved by right
clicking the status bar and hiding the "Vim Command Line" entry. The
only difference is that macro information will also be hidden.
@J-Fields
Copy link
Member

Didn't realize this was an issue (I guess not many people disable showmodename). Thanks for the fix!

@J-Fields J-Fields merged commit d480d49 into VSCodeVim:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants