Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vim strict ui extension #7049

Merged
merged 1 commit into from Sep 1, 2021
Merged

make vim strict ui extension #7049

merged 1 commit into from Sep 1, 2021

Conversation

sandy081
Copy link
Contributor

@sandy081 sandy081 commented Sep 1, 2021

Hi, this is developer from VS Code. As we are rolling out web extensions we are trying to fine tune and simplify the concepts around web extensions. As a result, we are no longer supporting web as an extension kind to identify as a web extension. Instead we infer it from other properties - See https://github.com/microsoft/vscode-docs/blob/vnext/api/extension-guides/web-extensions.md#web-extension-enablement for more details. With latest vsce, it will validate extension kind for appropriate values which are ui, workspace. Since this extension has web extension kind, this PR fixes it properly.

It seems vim aways wants to run close to UI, so it is recommended to mark it as strict ui extension so that it will run close to UI in any environment.

Hence changed vim extension kind to be strict ui.

@sandy081
Copy link
Contributor Author

sandy081 commented Sep 1, 2021

@rebornix FYI

@rebornix rebornix merged commit dadcbda into VSCodeVim:master Sep 1, 2021
@rebornix
Copy link
Member

rebornix commented Sep 1, 2021

@sandy081 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants