Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs with: Failed to handle key ... Cannot read property 'substring' of undefined #7513

Merged
merged 2 commits into from Feb 18, 2022

Conversation

elazarcoh
Copy link
Contributor

What this PR does / why we need it:
I think it should fix all the lately reported bugs with "Failed to handle key ... Cannot read property 'substring' of undefined"

Which issue(s) this PR fixes
fixes #7512
and lots more of them.

Special notes for your reviewer:

@elazarcoh
Copy link
Contributor Author

@J-Fields this still might have a race-condition.
Maybe it's safer to do

public async historyBack(): Promise<void> {
    //  ...
      this.historyIndex = Math.max(this.historyIndex - 1, 0);
   // ...
}

public async historyForward(): Promise<void> {
       // ....
      this.historyIndex = Math.min(this.historyIndex + 1, historyEntries.length - 1);
  // ...
}

@J-Fields
Copy link
Member

Can you elaborate? I'm not sure what race condition you're referring to

@J-Fields
Copy link
Member

Actually, I want to cut a release and this seems very reasonable so I'm gonna merge - if you still have concerns please let me know and we can make sure they're addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to handle key j: Cannot read property 'substring' of undefined
2 participants