Multi-Cursor Mode v 2.0 #811
Conversation
I can't believe I actually got it to work.
Conflicts: src/register/register.ts
| @@ -13,8 +13,12 @@ | |||
| } | |||
| ], | |||
|
|
|||
| "vim.hlsearch": false, | |||
There was a problem hiding this comment.
should we be checking in these settings? They are very much user-specific.
There was a problem hiding this comment.
My settings.json is objectively the best though... 😉
Okay, okay, we should probably add it to .gitignore. :P
| @@ -254,6 +258,17 @@ export abstract class BaseCommand extends BaseAction { | |||
| */ | |||
| isCompleteAction = true; | |||
|
|
|||
| supportsMultiCursor = true; | |||
|
|
|||
| multicursorIndex: number | undefined = undefined; | |||
There was a problem hiding this comment.
Nitpicking: I feel like you should capitalize the 'c'
There was a problem hiding this comment.
hmm, i am being inconsistent here...
| /** | ||
| * In multi-cursor mode, do we run this command for every cursor, or just once? | ||
| */ | ||
| public runsOnceForEveryCursor(): boolean { |
There was a problem hiding this comment.
Ah, I see why you did it this way.
|
|
||
| for (let i = 0; i < timesToRepeat; i++) { | ||
| vimState = await this.exec(position, vimState); | ||
| let timesToRepeat = this.canBePrefixedWithCount ? vimState.recordedState.count || 1 : 1; |
There was a problem hiding this comment.
This is the same as line 288? Can we execute this once outside the if block?
| let resultingCursors: Range[] = []; | ||
| let i = 0; | ||
|
|
||
| const cursorsToIterateOver = vimState.allCursors |
There was a problem hiding this comment.
Mind leaving a comment here about what's happening? This looks super magical to me :)
There was a problem hiding this comment.
I actually explained what was going on over here:
https://github.com/VSCodeVim/Vim/pull/811/files#diff-a7723f32fe6b05e135838f84e5c23c0fR965
Unfortunately I had to have similar logic in 2 places but I think the alternative is even worse. :P
Conflicts: src/register/register.ts
The other one got way out of control because I was trying to refactor the entire codebase. Undoing all that insanity and cutting it down to basics!