Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command is D in visual block mode. #957

Merged
merged 2 commits into from
Oct 21, 2016
Merged

Conversation

kyfk
Copy link
Contributor

@kyfk kyfk commented Oct 20, 2016

Yay! We love PRs! 🎊

I add a command is D in visual block mode.

It's like below ↓
10-21-2016 02-16-01

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@kyfk
Copy link
Contributor Author

kyfk commented Oct 20, 2016

How about this??

@rebornix
Copy link
Member

LGTM. @kooooya do you mind writing test cases for it, that would be easy.

@kyfk
Copy link
Contributor Author

kyfk commented Oct 21, 2016

I've just written a test code by https://github.com/VSCodeVim/Vim/pull/957/files#diff-635380ad4f966541a3e3e35a51293887R59 @rebornix

now, CI is green. But test failed that executed at my local environment. about below ↓

  556 passing (2m)

  2 failing



  1) register Can access '*' (clipboard) register:

      Cursor CHARACTER position is wrong.
      + expected - actual

      -134
      +4

      at Suite.suite (test/register/register.test.ts:31:3)


  2) register Can access '+' (clipboard) register:

      Cursor CHARACTER position is wrong.
      + expected - actual

      -134
      +4

      at Suite.suite (test/register/register.test.ts:38:3)

Why? and Is this good?

@xconverge
Copy link
Member

Those tests fail nearly every time for me locally but not on travis.

@xconverge
Copy link
Member

BTW are you registered for https://hacktoberfest.digitalocean.com/ @kooooya! You are doing great and we appreciate the help!

@johnfn
Copy link
Member

johnfn commented Oct 21, 2016

Looks good to me. Thanks, @kooooya! :)

@johnfn johnfn merged commit 56b0cba into VSCodeVim:master Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants