Skip to content

Commit

Permalink
fix: cannot open welcome page when offline (#1493)
Browse files Browse the repository at this point in the history
  • Loading branch information
scientificworld committed Apr 25, 2023
1 parent 8661322 commit 6137a9f
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions patches/feat-announcements.patch
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ index 46949b2..174e65f 100644
- reset(leftColumn, startList.getDomElement(), recentList.getDomElement());
+ reset(leftColumn, startList.getDomElement(), announcementList.getDomElement());
reset(rightColumn, featuredExtensionList.getDomElement());
@@ -982,2 +989,51 @@ export class GettingStartedPage extends EditorPane {
@@ -982,2 +989,55 @@ export class GettingStartedPage extends EditorPane {

+ private async buildAnnouncementList(): Promise<GettingStartedIndexList<AnnouncementEntry>> {
+ const renderAnnouncement = (announcement: AnnouncementEntry) => {
Expand Down Expand Up @@ -75,15 +75,19 @@ index 46949b2..174e65f 100644
+
+ if (showExtras) {
+ const branch = this.productService.quality === 'insider' ? 'insider' : 'master';
+ const res = await fetch(`https://raw.githubusercontent.com/VSCodium/vscodium/${branch}/announcements-extra.json`);
+ await fetch(`https://raw.githubusercontent.com/VSCodium/vscodium/${branch}/announcements-extra.json`)
+ .then(async res => {
+ if (res.ok) {
+ var extraAnnouncements = await res.json() as AnnouncementEntry[];
+
+ if (res.ok) {
+ var extraAnnouncements = await res.json() as AnnouncementEntry[];
+
+ this.announcementData = [...extraAnnouncements, ...BUILTIN_ANNOUNCEMENTS];
+ } else {
+ this.announcementData = BUILTIN_ANNOUNCEMENTS;
+ }
+ this.announcementData = [...extraAnnouncements, ...BUILTIN_ANNOUNCEMENTS];
+ } else {
+ this.announcementData = BUILTIN_ANNOUNCEMENTS;
+ }
+ })
+ .catch(err => {
+ this.announcementData = BUILTIN_ANNOUNCEMENTS;
+ });
+ } else {
+ this.announcementData = BUILTIN_ANNOUNCEMENTS;
+ }
Expand Down

0 comments on commit 6137a9f

Please sign in to comment.