Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify winget install command #1251

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

osfanbuff63
Copy link
Contributor

winget uses IDs and winget install vscodium might work, but usually it's better to use winget install -e --id VSCodium.VSCodium to make sure it will install the correct package.

`winget` uses IDs and `winget install vscodium` *might* work, but usually it's better to use `winget install -e --id VSCodium.VSCodium` to make sure it will install the correct package.
@osfanbuff63 osfanbuff63 changed the title fix(readme): clarify winget install command docs: clarify winget install command Sep 15, 2022
@daiyam
Copy link
Member

daiyam commented Sep 19, 2022

@GitMensch @vedantmgoyal2009 What do you think? I think it's fine as it is.

@GitMensch
Copy link
Collaborator

I have no usage-information on winget, so this may be reasonable (I'd personally try "vscodium", not the qualified version).
In general I'd suggest to change the install part to a minimum in that file and instead link to either https://vscodium.com/#install or its source https://github.com/VSCodium/vscodium.github.io/blob/master/_posts/2000-01-05-install.md

@vedantmgoyal9
Copy link
Contributor

As long as any other contributors doesn't play with the manifests and change the Moniker field, it is fine as it is.

@AlexisComix
Copy link

From what I have tested, winget install vscodium installs from VSCodium.VSCodium fine. Changing ```bash to ```cmd makes no functional difference because cmd is not recognised by Linguist. However, changing it to something other than bash could be good as Windows does not use bash without WSL. While a change to ```bat or ```batch would also have no visual difference to ```bash, it is recognised by Linguist and would make sense as ```bash may be slightly misleading.

@GitMensch
Copy link
Collaborator

Changing ```bash to ```cmd makes no functional difference because cmd is not recognised by Linguist. However, changing it to something other than bash could be good as Windows does not use bash without WSL. While a change to ```bat or ```batch would also have no visual difference to ```bash, it is recognised by Linguist and would make sense as ```bash may be slightly misleading.

I think you've meant the install docs and the code fence used there - I've just changed all three windows entries from "bash" to "cmd".

@daiyam daiyam merged commit 6333caa into VSCodium:master Sep 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants