Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-ppc64le Architecture Support in Build Configuration #1527

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add linux-ppc64le Architecture Support in Build Configuration #1527

merged 1 commit into from
Jun 5, 2023

Conversation

lex-ibm
Copy link
Contributor

@lex-ibm lex-ibm commented May 22, 2023

Summary

This pull request introduces support for building VSCodium on the linux-ppc64le platform.

Changes

A new build target for the linux-ppc64le platform has been added to gulpfile.reh.js:

{ platform: 'linux', arch: 'ppc64le' },

Motivation

The linux-ppc64le (PowerPC 64-bit Little Endian) platform is commonly used in high-performance computing environments and by the scientific community. There have been numerous requests for Microsoft's VSCode to support this platform, but progress has been slow. By adding support for linux-ppc64le in VSCodium, we are satisfying a previously unfulfilled need within the community. This not only serves those who have been requesting this feature but also makes VSCodium more accessible to those using this architecture in scientific and research contexts.

Testing

Before merging this pull request, it's important to test the build process on a linux-ppc64le system to ensure the functionality works as expected. Any volunteers or guidance on accomplishing this would be greatly appreciated.

@daiyam
Copy link
Member

daiyam commented May 22, 2023

The workflows would need to be updated to support the new platform. At least, adding a new OS at

matrix:
include:
- vscode_arch: x64
npm_arch: x64
image: vscodium/vscodium-linux-build-agent:bionic-x64
- vscode_arch: arm64
npm_arch: arm64
image: vscodium/vscodium-linux-build-agent:buster-arm64

A GitHub Action Runner supporting that architecture will be required.

Then, more testing will need to be done.

@lex-ibm
Copy link
Contributor Author

lex-ibm commented May 31, 2023

What would be the requirements for the Runner? I pocked around and found this link.
Accelerate your open source development with access to IBM Power resources

@daiyam
Copy link
Member

daiyam commented May 31, 2023

I've found this: https://github.com/orgs/community/discussions/24921
So it's unlikely to have a runner on ppc64le.
But maybe with QEMU: https://github.com/uraimo/run-on-arch-action

Which desktop is running ppc64le?

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 4, 2023

I've modified the actions to include some tasks to build for ppc64le, but it still fails to build for desktop due to electron not being available for ppc64le.
I'll get that fixed up before marking the PR ready.

Which desktop is running ppc64le?

I'm currently using the native macOS client to connect to a remote el8.ppc64le (using jeanp413/open-remote-ssh#93), and this seems to be working just fine.

@daiyam
Copy link
Member

daiyam commented Jun 4, 2023

I'm currently using the native macOS client to connect to a remote el8.ppc64le (using jeanp413/open-remote-ssh#93), and this seems to be working just fine.

Should you focus only the reh binary? Not sure how to avoid the electron dependency
Maybe with in the vscode dir:

export ELECTRON_SKIP_BINARY_DOWNLOAD=1
export PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1
yarn // to install the dependencies

yarn gulp compile-build
yarn gulp minify-vscode-reh
yarn gulp vscode-reh-ppc64le-linux-min-ci

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 4, 2023

I've pushed the changes I believe are necessary for building vscodium-reh. I'll be changing the PR to ready for review.

@lex-ibm lex-ibm marked this pull request as ready for review June 4, 2023 17:29
build.sh Outdated Show resolved Hide resolved
prepare_assets.sh Outdated Show resolved Hide resolved
@daiyam daiyam merged commit f7fc439 into VSCodium:master Jun 5, 2023
@daiyam
Copy link
Member

daiyam commented Jun 5, 2023

vscodium-reh-linux-ppc64le-1.78.2.23132.tar.gz is available. Can you test it?

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 5, 2023

IT WORKS!!!!! 🚀

@lex-ibm
Copy link
Contributor Author

lex-ibm commented Jun 5, 2023

Me and a few others will be using this for a few days to test how stable it is, but I'm optimistic that this is going to make a lot of people happy.
Thanks for the support and guidance provided, it was awesome to be able to coordinate with you to get this out to the public.

@daiyam
Copy link
Member

daiyam commented Jun 5, 2023

Since you made the PR, I was happy to help. 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants