fix(patches): enable electron sandbox #1530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The electron sandbox disables the node integration within the renderer process. However, the
custom-gallery
patch required the use of therequire()
function, causing the renderer to fail loading within the sandbox. To resolve this issue, the function that requires user'sproduct.json
has been moved tomain.js
, and the user'sproduct.json
is now assigned to global scope which can be used inproduct.ts
.Fixes #1482
This patch works on stable (1.78.2) and insider (1.79.0) versions