-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New light-colored macOS icon, consistent with logo on other platforms #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed few places , for Linux .
I really dont know which ones are used for Linux, except letterpress*
are not obviously used. On Ubuntu it shows as green icon on its app store .
vscodium\icons\codium_only.svg
vscodium\src\src\vs\workbench\browser\media\code-icon.svg
vscodium\src\src\vs\workbench\browser\parts\editor\media\letterpress-dark.svg
vscodium\src\src\vs\workbench\browser\parts\editor\media\letterpress-hc.svg
vscodium\src\src\vs\workbench\browser\parts\editor\media\letterpress.svg
vscodium\src\resources\linux\code.png
vscodium\src\resources\linux\rpm\code.xpm
The following files must not be updated.
|
Voting was held and the blue one was chosen. You cannot change it without voting again. |
@hazarek Could you please link the voting results link here? |
@pmahend1 Presumably referring to the vote here: #591. I’m only a user of this project, so I wasn’t aware of that discussion till now. As @h0adp0re said then, the only choices presented were 👍 (use the dark icon, which follows the Big Sur “rounded square” guidelines), or 👎(keep the circular light icon, which doesn’t). No option was presented to simply expand the light icon into a rounded square, so that’s what I’ve done here. With all due respect @hazarek, I understand that you designed this icon, and are quite attached to keeping it. But as a user on several platforms, I would much rather if macOS used the “official” Codium icon, for consistency’s sake. You’re free to use whatever design you want on your own system, but it feels natural to use what is inarguably the “default” design by default. I’m interested in what @stripedpajamas thinks of this. Is this something that should be put to another popular vote? |
Thank @morellam-dev I personally prefer the blue back-grounded icon . But providing just 👍🏻 and 👎🏻 to vote without much explanation seems like incorrect way to poll. People tend to use 👍🏻 since they are more familiar with that , people dont usually use 👎🏻 unless they really want to criticize something on online. Could have used a third party tool like google forms or something. If blue backgrounded is preferred then Windows and Linux icons need to be updated. |
@morellam-dev The two icon can change dynamically when macOS supports adaptive icons. I don't know if this is possible right now; |
@morellam-dev Are you using a dark theme/mode? Is this why you would like a lighter icon? |
@daiyam I sometimes use macOS in dark mode, but it's not really the lightness or darkness that bothers me. It's just that the aesthetics (colors, drop shadows, gradient direction etc.) in the macOS icon are so distinct from the icon in the Windows/Linux builds that it feels disharmonious. I use all three builds pretty frequently, and I just happen to prefer the "white and cyan" version. From #4 (comment), it looks like jaredreich actually created a version of the original blue algae icon which has the colors inverted. I mocked up some Big Sur-style derivatives of those (second row), and also a version with the colors darkened to improve contrast, inspired by Hazarek's design (third row). I actually quite like these designs, so I wonder if it's the drop shadow under the emblem that's not appealing to me?
Files here: vs_codium_sur_icons.zip. At the very least, these might be useful for people to use as alternative icons on Big Sur . |
If white icon causes strain and not conform to accessibility thresholds then there is no need to keep it on Linux and Windows. @daiyam IMO its good to have another poll to accommodate opinions |
I think the icons on the right are suitable for windows, linux and mac. I think the official icon should be changed to white on blue. I have no problem with the blue ones. |
I am just now learning of this project, I like the light color background icon but I think that the design itself is way too busy with all the little bulby ends. |
We are not talking about Linux here, we're talking about MacOS. |
That should be solved together with #1218, which also includes the next, more fine grained voting (I think we're still in the discussion phase), no? |
@GitMensch They should be same on all platform. |
With or without a secondary set for dark mode? |
A secondary set if it can be done. |
-1 i prefer the current icon tired of all these white background icons for everything |
Closing due to: |
Related to #763. I think the current macOS icon is an interesting design, but I don't like how different it is from the icons on other platforms, and I personally prefer the lighter colors from the Linux/Windows icon. With that in mind, I created this alternative which is identical, except the background is a rounded rectangle.
Current icon:
Alternative icon:
This PR simply replaces src/resources/darwin/code.icns with this new icon, scaled down to 512px and converted using libicns.