Fix extension marketplace #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add loop to apply patches
2 tasks
GitMensch
reviewed
Jul 29, 2021
| fi | ||
| fi | ||
| done | ||
|
|
There was a problem hiding this comment.
That looks like a reasonable thing to include in any case - if you provide that as separate PR and have tested it I'd like to merge that now (if you can't do that yet).
|
|
|
So, shouldn't we close this and have microsoft/vscode#129360 included as patch instead? |
|
@GitMensch I think you have commented on the wrong issue... no? |
|
Totally. |
|
The I will revert the fix when CORS are correctly available on open-vsx.org. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #746 by reverting the CORS checks (added in
v1.58).Additionally, it's adding a loop to apply patches.
@stripedpajamas If by the
v1.59.0, the CORS haven't being added to openvsx, we should apply this PR.