Add Riviera's global libs as builtin libraries #374
Conversation
This is similar to what is done in modelsim_interface.py.
vunit/rivierapro_interface.py
Outdated
| """ | ||
| mapped_libraries = self._get_mapped_libraries() | ||
| for library_name in mapped_libraries: | ||
| if not project.has_library(library_name): |
There was a problem hiding this comment.
A spot a potential problem here.
-
Consider if the user adds a library
lib2to theirrun.pyfile and runs once. The library will be added tolibrary.cfgand will not be considered a built-in library. -
The user removes
lib2from theirrun.pyand runs again.vlistwill readlibrary.cfgand discoverlib2which will be added as a built-in library. This means any references tolib2will be ignored by VUnit instead of flagged as errors which it should since the library is not there anymore.
The possible solution would maybe be a bit out of scope of this PR. But I think that the RiviveraProInterface should not depend on the state of the library.cfg file in the form of reading it but rather always overwrite it regardless of what was there before. The built-in libraries can be discovered by running vlist without any library.cfg which will just show the built-in libraries.
No description provided.