use pathlib #626
Merged
use pathlib #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eine
force-pushed
the
use-pathlib
branch
3 times, most recently
from
04cdf1d
to
d05ff3b
Compare
eine
force-pushed
the
use-pathlib
branch
3 times, most recently
from
0115d6b
to
3e0d581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, all usages of
abspath,basename,dirname,exists,isdir,join,isfile,splittext... fromos.pathare replaced withPathfrompathlib. A few resources fromos.pathare kept (getmtime,relpath,splitdrive,commonprefix).The modifications in this PR should NOT introduce any breaking change, as I tried to keep internal data types (strings).
In the second commit, some type annotations are added to
vunit/ui/__init__.py.Actually, this PR is a cleaning phase before properly using
Pathinternally. Future work should consist on evaluating when explicit conversions tostrcan be avoided. I believe this should be done together with adding type annotations, as it allows to better catch inconsistencies.