run_vivado fails when tcl_file_name contains spaces in the path

[nfrancque]

Unfortunately Python can install to Program Files on Windows, causing the path passed to run_vivado by create_compile_order_file to also contain a space because extract_compile_order.tcl is contained within the install. The problems caused by this probably vary, but looks like it has caused batch to split up the commands and fail entirely.

I think that surrounding tcl_file_name and also each of tcl_args independently with quotes for the string passed into check_call would solve it for both OSes?

[eine]

@nfrancque would you mind trying removing shell=True from

vunit/vunit/vivado/vivado.py

Line 136 in af7b89d

check_call(cmd, cwd=cwd, shell=True)

?