Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compile_builtins and vunit.verilog #764

Merged
merged 7 commits into from
Apr 23, 2023
Merged

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Oct 23, 2021

Close #559.

This PR is the complement of #757. There, deprecation are announced. Here the features are removed.
This PR will be kept as a draft, because it is expected to be merged in future releases, not in the next one.

@umarcor
Copy link
Member Author

umarcor commented Nov 9, 2021

@LarsAsplund after the discussion in #757, I updated this PR to include a larger and coloured note about the breaking change. I also updated the documentation to make the content about (V)HDL libraries/utilities easier to find and understand. In order to do so, I propose to create a "Guides" section:

image

The proposed content for the HDL Libraries section is based on #765.

@umarcor umarcor force-pushed the builtins-remove branch 8 times, most recently from 1032615 to 943d3f7 Compare November 13, 2021 17:29
@umarcor umarcor force-pushed the builtins-remove branch 2 times, most recently from 5b0230e to e7d1f78 Compare November 14, 2021 02:34
@umarcor umarcor force-pushed the builtins-remove branch 2 times, most recently from 2e66165 to 5023c4f Compare January 9, 2022 11:40
@eine eine modified the milestones: v5.0.0, v5x Apr 19, 2023
@umarcor umarcor force-pushed the builtins-remove branch 3 times, most recently from 4184d05 to a1d4746 Compare April 23, 2023 15:42
@eine eine modified the milestones: v5.1.0, v5.0.0 Apr 23, 2023
@umarcor umarcor force-pushed the builtins-remove branch 2 times, most recently from 5e2d710 to a9f5e1e Compare April 23, 2023 21:48
@umarcor umarcor marked this pull request as ready for review April 23, 2023 21:55
@eine eine merged commit e59fdb0 into VUnit:master Apr 23, 2023
@umarcor umarcor deleted the builtins-remove branch April 23, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add builtins by default
2 participants