Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axi_lite_master wait behaviour if idle #797

Merged
merged 1 commit into from Nov 6, 2022

Conversation

eschmidscs
Copy link
Contributor

The axi_lite_master did wait forever on wait_for_idle if it was already idle.
I tried to fix it here.

@eschmidscs
Copy link
Contributor Author

If I understand the failing task, it is not related to my change. Can anyone check this please?

@umarcor
Copy link
Member

umarcor commented Jan 18, 2022

If I understand the failing task, it is not related to my change. Can anyone check this please?

It seems that Sphinx was updated to v.4.4.0 and it is now showing that error. Please, replace the reference reported in the error with:

:vunit_example:`vhdl/array`

@LarsAsplund
Copy link
Collaborator

Looks good from my point of view. The only alternative solution I can come to think of is to push an extra dummy "token" into the queue after the request message and then pop that at the end of the bus process. The component is idle if the queue is empty. I can't say that one is better or more beautiful than the other so you can decide.

@eschmidscs
Copy link
Contributor Author

@umarcor Tried to do that, the new link does not seem to work. A similar error shows up now, but I can't even find that static link in examples.rst?

@umarcor
Copy link
Member

umarcor commented Feb 5, 2022

@eschmidscs I fixed doc issues in master. If you rebase, it should be green.

@creiter64
Copy link

I'm hitting this error, can this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants