Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port type signal #826

Merged
merged 3 commits into from
May 13, 2022
Merged

Port type signal #826

merged 3 commits into from
May 13, 2022

Conversation

dalex78
Copy link
Contributor

@dalex78 dalex78 commented May 10, 2022

The changement are those implemented by @eschmidscs in pull request #792 with the changes requested by Lars.
Note that there is also a modification of the regex from:

code = re.sub("\bsignal\b", "", code)

to

code = re.sub(r"\bsignal\b", "", code)

otherwise the tests fail. The python documentation about the word boundary states:

There are two subtleties you should remember when using this special sequence.
First, this is the worst collision between Python’s string literals and regular expression sequences. In Python’s string literals, \b is the backspace character, ASCII value 8. If you’re not using raw strings, then Python will convert the \b to a backspace, and your RE won’t match as you expect it to.
Second, inside a character class, where there’s no use for this assertion, \b represents the backspace character, for compatibility with Python’s string literals.

@dalex78
Copy link
Contributor Author

dalex78 commented May 10, 2022

The 517 tests all pass (using tox -v -e py39-unit-modelsim).

@dalex78
Copy link
Contributor Author

dalex78 commented May 10, 2022

@LarsAsplund I suggest to merge and close this PR and to close without merging #792.

@eschmidscs
Copy link
Contributor

@dalex78 Thanks for fixing the fix and properly testing it!

Copy link
Member

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants