Error with NVC and the --gui flag

[0dinD]

I just tried the NVC simulator support, which worked well for me (apart from this one issue). NVC seems quite a bit faster than GHDL, so that's awesome!

But there's one error I had to fix when running with the --gui flag:

Traceback (most recent call last):
  File "/home/odin/git/vunit/vunit/test/runner.py", line 244, in _run_test_suite
    results = test_suite.run(output_path=output_path, read_output=read_output)
  File "/home/odin/git/vunit/vunit/test/list.py", line 105, in run
    test_ok = self._test_case.run(*args, **kwargs)
  File "/home/odin/git/vunit/vunit/test/suites.py", line 72, in run
    results = self._run.run(*args, **kwargs)
  File "/home/odin/git/vunit/vunit/test/suites.py", line 178, in run
    sim_ok = self._simulate(output_path)
  File "/home/odin/git/vunit/vunit/test/suites.py", line 237, in _simulate
    return self._simulator_if.simulate(
  File "/home/odin/git/vunit/vunit/sim_if/nvc.py", line 293, in simulate
    stdout.write(f'{" ".join(cmd)}\n')
TypeError: sequence item 1: expected str instance, PosixPath found

The solution I applied was to use [str(wave_file)] instead of [wave_file] here:

vunit/vunit/sim_if/nvc.py

Line 287 in 1bc4d06

cmd = ["gtkwave"] + shlex.split(self._gtkwave_args) + [wave_file]

[umarcor]

That's correct. @0dinD do you want to propose a PR?

For reference, in GHDL the Path is converted to str in

vunit/vunit/sim_if/ghdl.py

Line 338 in 1bc4d06

data_file_name = str(Path(script_path) / f"wave.{self._gtkwave_fmt!s}")

.