Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic on invalid input #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JayKickliter
Copy link

The upstream bloom crate we depend on panics when items_count == 0, bitmap_size == 0, fp_rate == 0.0, or fp_rate == 1.0. This would kind of makes sense, but only if it was documented, which it isn't.

To save debugging Erlang pattern mismatches, and remove the overhead of stack-unwinding, let's return an explicit error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant