Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solved issue #120 and #136 #121

Merged
merged 5 commits into from
May 25, 2024
Merged

solved issue #120 and #136 #121

merged 5 commits into from
May 25, 2024

Conversation

hiranj-kotak
Copy link
Contributor

No description provided.

sapatevaibhav
sapatevaibhav requested changes May 22, 2024
View reviewed changes
Copy link
Member

@sapatevaibhav sapatevaibhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not proper behavior. When I click on any image on the homepage, all the images change height.

@hiranj-kotak
Copy link
Contributor Author

This is not proper behavior. When I click on any image on the homepage, all the images change height.

okay i will change it asap and can you pls mark the issue under gsoc

@hiranj-kotak
Copy link
Contributor Author

hey @sapatevaibhav i have made the changes pls review it

@hiranj-kotak hiranj-kotak changed the title solved issue #120 solved issue #120 ans #136 May 23, 2024
@hiranj-kotak hiranj-kotak changed the title solved issue #120 ans #136 solved issue #120 and #136 May 23, 2024
@sapatevaibhav
Copy link
Member

Solving multiple issues in single pull will cause problems while distributing scores at GSSoC.

@sapatevaibhav sapatevaibhav added gssoc Girl Script Summer of Code level1 Easy to solve issues for GSSoC'24 labels May 25, 2024
@sapatevaibhav sapatevaibhav merged commit e5bd3e3 into VaibhavCodeClub:master May 25, 2024
1 check passed
This was referenced May 25, 2024
Closed
Closed
@hiranj-kotak
Copy link
Contributor Author

Solving multiple issues in single pull will cause problems while distributing scores at GSSoC.

Okay

Thanks for the information
And can you pls suggest what should i do now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapatevaibhav sapatevaibhav sapatevaibhav requested changes

Assignees

@hiranj-kotak hiranj-kotak

Labels
gssoc Girl Script Summer of Code level1 Easy to solve issues for GSSoC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiranj-kotak @sapatevaibhav