Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert props order check on update #17

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

tafelito
Copy link
Contributor

This fixes an issue that prevents updating at the same time zoom and aspect ratio. Because computeSizes also recomputes crop position, if aspect ratio and/or zoom are changed, both values will be updated

Copy link
Owner

@ValentinH ValentinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@ValentinH ValentinH merged commit 578fb0e into ValentinH:master Oct 22, 2018
@ValentinH
Copy link
Owner

Released as 1.6: https://github.com/ricardo-ch/react-easy-crop/releases/tag/v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants