Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onError prop to Img #18

Merged
merged 2 commits into from
Oct 25, 2018
Merged

add onError prop to Img #18

merged 2 commits into from
Oct 25, 2018

Conversation

bexoss
Copy link
Contributor

@bexoss bexoss commented Oct 23, 2018

add onError prop to Img

add onError prop to Img
@ValentinH
Copy link
Owner

Hi,

Thanks for contributing. However onImgError is not defined. What are you trying to do?

@bexoss
Copy link
Contributor Author

bexoss commented Oct 24, 2018

@ValentinH Oh, I forgot props., Could you add the onError handler for <Img>?
I want to use fallback image if the src not exist.

@ValentinH ValentinH self-requested a review October 24, 2018 07:47
@ValentinH
Copy link
Owner

This looks good to me, just before merging, could you add this to the documentation?

@ValentinH ValentinH mentioned this pull request Oct 24, 2018
@bexoss
Copy link
Contributor Author

bexoss commented Oct 25, 2018

Okay, I added pull request. Should I used same branch? Actually I don't have enough experiences to pull request to other project. So it little confused me. Anyway I added pull request if you find any wrong please edit it correctly :) I want to push commit to this same branch but I found the documentation updated few hours ago so I created new one to new docs. I don't know git handle it automatically or not :(

@ValentinH
Copy link
Owner

Indeed, you should have done it in the same PR. But let's merge both :)

@ValentinH ValentinH merged commit f7caf8c into ValentinH:master Oct 25, 2018
@ValentinH
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants