Export props to allow other libraries to reference it #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4b11ed:
|
ValentinH
reviewed
Oct 12, 2020
src/index.tsx
Outdated
| @@ -12,7 +12,7 @@ import { | |||
| } from './helpers' | |||
| import cssStyles from './styles.css' | |||
|
|
|||
| type Props = { | |||
| export type EasyCropperProps = { | |||
There was a problem hiding this comment.
As the component is named Cropper, I would name this CropperProps.
There was a problem hiding this comment.
@ValentinH Can do, but thought due to NPM name it would be best to relate to that i.e react-easy-crop therefor EasyCropper
There was a problem hiding this comment.
Cropper is the name used in the docs so I'd use this :)
|
Thanks for this PR. It has been published under v3.2.1 🎉 |
|
@all-contributors please add @labithiotis for code |
|
I've put up a pull request to add @labithiotis! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple PR to export props to allow them to be reference by other libraries.