Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable page scrolling on iOS when user scrolls inside of crop component #24

Merged
merged 2 commits into from
Mar 9, 2019

Conversation

yokelpole
Copy link
Contributor

@yokelpole yokelpole commented Mar 8, 2019

Currently on iOS the entire page scrolls when a user attempts to move the cropped area:
before

This makes it so that we prevent that behaviour (there is a little bit of scrolling on the page itself to show that functionality is unaffected by my change):
fixed

(Sorry for the choppiness in the examples - the iOS simulator is a little slow. I have verified that this happens on an iPhone 7 with iOS 12.)

@ValentinH
Copy link
Owner

Hey thanks for this.

Indeed, I might have never tried this on a scrollable page (I was always in a fullscreens pop-up).

Before merging, I'll try it on other devices just to be sure nothing else is affected. 🙂

@ValentinH ValentinH merged commit 76aa310 into ValentinH:master Mar 9, 2019
@ValentinH
Copy link
Owner

Tested and merged! 👍

BTW your app looks great. If it's public, I'd love to see how you use this library 😃

@ValentinH
Copy link
Owner

Published as 1.8.1

@yokelpole
Copy link
Contributor Author

Sure thing! We're using the library at http://www.change.org for our smart images uploader. It's a feature that allows users to upload multiple pictures to their petitions so that they can test what image is the most effective for link sharing.

There's no easily available way to access the page without starting a petition, but if you do start a petition you can access the page by going to /p/{your-petition-slug}/smart and you'll be able to see it in action there.

@ValentinH
Copy link
Owner

ValentinH commented Mar 15, 2019

This makes me so happy to see this project used for such a cool website! 🎉

@ValentinH
Copy link
Owner

BTW, the french translation of the title is incorrect:
image

It should be "Testez d'autres images..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants