Add ability to provide a nonce for style injection #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3205ae7:
|
ValentinH
added
enhancement
|
Thanks for this contribution. I understand that this could be useful for some people and avoid having to opt-out of the automatic style injection. Let's merge this! |
|
馃殌 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 馃憢
This is somewhat related to #139 in that we're also using a content security policy that's preventing the inline styles from being applied.
I realize that one way around this is to pass the
disableAutomaticStylesInjectionprop and add the styles manually, but I was curious if you'd be open to adding anonceprop so that the injectedstyletag can have itsnonceattribute set and we can continue to use automatic style injection along with our CSP.